[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29221 [Core Tor/Tor]: Tooling to track code-style/best-practices violations

#29221: Tooling to track code-style/best-practices violations
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2       |  Actual Points:  4
  teor-merge                                     |
Parent ID:                                       |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:28 teor]:
 > Hmm, no, travis runs with python 2.7.6 by default, so we should fix the
 script so it works with python3.

 Thanks for catching that.

 Seems like `checkIncludes.py` is also a python3 script but it also runs
 with python2 in jenkins/travis because of the `from __future__ import
 print_function` trick.

 Please see https://github.com/torproject/tor/pull/796 for a branch that
 does exactly that.

 Marking as merge_ready but feel free to push down to needs_rev if needed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29221#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs