[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25658 [Applications/Tor Browser]: Activity 2.1: Improve user understanding and user control by clarifying Tor Browser's security features
#25658: Activity 2.1: Improve user understanding and user control by clarifying Tor
Browser's security features
-------------------------------------------------+-------------------------
Reporter: isabela | Owner:
| antonela
Type: project | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ux-team, GeorgKoppen201812, | Actual Points:
TorBrowserTeam201903R, tbb-8.5 |
Parent ID: | Points:
Reviewer: | Sponsor:
| Sponsor17
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
I've been looking at commit 843976bb2f88dc08cbefc28024b4a271a5cfa92a (the
Torbutton patch). Two small requests:
1) I think the Torbutton icon fixup (aka #27478) is orthogonal to the sec
slider changes. It's fine having both on the same branch but could you put
them into different commits (with own bug numbers etc.) and adapt the
commit message? That way it's easier to keep track of the changes.
2) Looking at your new SVG icons, it seems you have added some superflous
whitespace, both at the end of
{{{
+ <polygon points="5,7 9,15 1,15" fill="#414141"/>
}}}
and at the beginning of
{{{
+ <path d="M8.27272727 5.0C8.49625435 5.67889606 9.03172133
6.21869701
}}}
Please remove them. (And, yes, not force-pushing makes reviewing at lot
easier ;) )
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25658#comment:96>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs