[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29734 [Obfuscation/Snowflake]: Broker should receive country stats information from Proxy and Client
#29734: Broker should receive country stats information from Proxy and Client
-------------------------------------+--------------------------------
Reporter: cohosh | Owner: cohosh
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone:
Component: Obfuscation/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: snowflake, geoip, stats | Actual Points:
Parent ID: #29207 | Points: 1
Reviewer: ahf | Sponsor: Sponsor19
-------------------------------------+--------------------------------
Comment (by cohosh):
Here's a new candidate: https://github.com/cohosh/snowflake/compare/geoip
In addition to the changes above, here are the other changes I made:
Replying to [comment:8 ahf]:
> - I don't know if this is a common thing in Go code to do, but in many
functional languages where you have type aliases people tend to do type
aliases for `string` types to make them "more specific". In this case the
country-string type could be called `Country` so the metrics table would
be a mapping of a Country to a monotonically increasing counter.
I did that for CountryStats (which is the map from country codes to
counts) is doing this for the country strings too noisy?
> - What should we do with these values when they are here? Should we have
an API end-point that can dump them? Should we save them to a log file
with some heartbeat interval? Chelsea Komlo showed me a neat library for
collecting internal metrics in Go applications, but it might be too early
to introduce additional dependencies just for this. It was this library:
https://github.com/armon/go-metrics
I think it's still very early... my suggestion is to do something simple,
close this ticket, and then think about what we want a bit more before
adding new dependencies. Right now it just logs the country counts to a
log file every hour
>Oh, and more thing I forgot. Should we have a SIGHUP handler that reloads
the tables?
Added.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29734#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs