[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX
#28329: Design TBA+Orbot configuration UI/UX
-------------------------------------------------+-------------------------
Reporter: sysrqb | Owner: tbb-
| team
Type: enhancement | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, ux-team, TBA-a3, | Actual Points:
TorBrowserTeam201903, tbb-8.5 |
Parent ID: | Points:
Reviewer: | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Looking over `28329_20` I got some new nits:
`all the expected preferences are is` <- s/are is/are/
`// If bridgesLine1 was not null, then append a newline.` <-
`bridgesLine1` can be `null` and we still can land there with
`bridgeLine2` being not null (which can happen if a user for some reason
leaves the first line out but starts to populate the second (and third
line) instead; so maybe "If bridgesLine1 or bridgesLine2 was not null"
`Log.i(LOGTAG, "provideBridge is empty. Disabling.");` I feel we should
only emit his log line or a similar one if we are actually disabling
bridges, but that's not clear at that point. Thus, please move this line
to a place where disabling bridges is essentially certainly to happen (and
maybe do a "provideBridge is" -> "custom bridges are").
Otherwise this looks okay. I won't push fixup commits to `tor-
browser-60.6.esr-8.5-1` as there a probably major revisions coming taking
that into account.
For posterity, the patches in `28329_19` got applied to `tor-
browser-60.5.1esr-8.5-1` as commits
0db4c9243320d2c516329949ee17e8b0a5b13624
a6e87093856101ec93bbeaf93eed22ac77031f73
fbf54c71e26a64859f953e18a34e5c9e8831f071
e4d2df5e776b6270b5eb98f4b718ea6eb5ea5094
87d6c829225d271ba94fa21672b157085dbf1ad9
and should get shipped in 8.5a9.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28329#comment:78>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs