[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28636 [Core Tor/Tor]: Address WTF-PAD comments by Nick (2018-11-27 over IRC)

#28636: Address WTF-PAD comments by Nick (2018-11-27 over IRC)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding, 041-proposed, network-team-           |
  roadmap-2019-Q1Q2                              |
Parent ID:  #28632                               |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision
 * version:   => Tor: 0.4.0.1-alpha
 * milestone:  Tor: unspecified => Tor: 0.4.1.x-final


Comment:

 Here are things that need revision:
 * Please fill in the actual points on this ticket.
 * This is a bug on code that was released in 0.4.0.1-alpha, so it needs a
 changes file.
   * Was any of this code released earlier than 0.4.0.1-alpha?
 * I did a review, I found at least one potential bug, and one typo:
   * https://github.com/torproject/tor/pull/819
 * I don't know enough to know if this code needs spec changes:
   * The only functional change I can see is padding is disabled in dormant
 mode.

 Here are the things I did:
 * The CI passed on the original pull request.
 * The pull request is based on master, so I'm setting the milestone to
 0.4.1 with no backport.
 * This branch has fixups, squashed to bug28636_squashed and made a pull
 request:
   * https://github.com/torproject/tor/pull/819
 * I reviewed the squashed version.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28636#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs