[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  034-removed-20180328                           |
Parent ID:                                       |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by neel):

 My old PR has asn's commit from his PR, as well as another commit for .

 I did not include a test, but he reason why a test isn't added for
 `add_ed25519_to_dir()` is because the similar RSA functions
 (`add_fingerprint_to_dir()`) were inside a `#define 0` in `test_dir.c`:

 {{{
 #if 0
   /* Okay, now for the directories. */
   {
     fingerprint_list = smartlist_new();
     crypto_pk_get_fingerprint(pk2, buf, 1);
     add_fingerprint_to_dir(buf, fingerprint_list, 0);
     crypto_pk_get_fingerprint(pk1, buf, 1);
     add_fingerprint_to_dir(buf, fingerprint_list, 0);
   }

 #endif /* 0 */
 }}}

 and wouldn't have run in the tests.

 My old PR is used for these changes:
 https://github.com/torproject/tor/pull/682

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs