[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29756 [Core Tor/Tor]: Check for correct header macro guards.
#29756: Check for correct header macro guards.
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status: merge_ready
Priority: Low | Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points: .1
Parent ID: | Points: .1
Reviewer: cohosh | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Changes (by cohosh):
* status: needs_review => merge_ready
Comment:
Looks good!
The checkSpace.pl script could use some comments stating that the new
addition checks header files for #ifndef/#define pairs. Something along
the lines of the {{{# Warn about}}} comments used in other parts of the
script.
This is a very quick fix so I'm putting this in merge_ready.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29756#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs