[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

#33216: Add Android Host and ABI Info to RBM.conf
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam202002                           |
Parent ID:  #28704                               |         Points:
 Reviewer:  boklm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 To provide some context on this issue

 For clang60 in android NDK 17, we see


 {{{
 Dynamic section at offset 0x3940a18 contains 33 entries:
   Tag        Type                         Name/Value
  0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
  0x0000000000000001 (NEEDED)             Shared library: [librt.so.1]
  0x0000000000000001 (NEEDED)             Shared library: [libdl.so.2]
  0x0000000000000001 (NEEDED)             Shared library: [libtinfo.so.5]
  0x0000000000000001 (NEEDED)             Shared library: [libz.so.1]
  0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]
  0x0000000000000001 (NEEDED)             Shared library: [libc++.so.1]
  0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]
  0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 }}}

 Google changed this to optional in NDK 18 (which we haven't upgraded to).

 More info: https://github.com/android/ndk/issues/574

 We can solve this by installing libtinfo5 as a dependency. This appears to
 have not worked for tor project since the var/deps in the tor/config file
 (which did not contain the libtinfo5 dep) were not merging with the dep
 section in rbm.conf which did contain the libtinfo5 dep. At least this is
 how I'm interpreting the results based on multiple builds.

 I'll fix this by removing the soft link in rbm.conf and adding the
 libtinfo5 dep in the tor config file.

 https://github.com/sisbell/tor-browser-build/tree/bug-33216a

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33216#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs