[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31011 [Core Tor/Tor]: Make the bridge authority reject private PT addresses when DirAllowPrivateAddresses is 0
#31011: Make the bridge authority reject private PT addresses when
DirAllowPrivateAddresses is 0
--------------------------+------------------------------------
Reporter: teor | Owner: cjb
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-pt | Actual Points:
Parent ID: #31009 | Points: 1
Reviewer: ahf | Sponsor: Sponsor28-can
--------------------------+------------------------------------
Comment (by teor):
Replying to [comment:26 cjb]:
> Thank you! I think the line is just named `transport` in the extra-info
doc, and there can be 0-to-many of them. So it sounds like a new
`transports` field in the `extrainfo_t` struct should be a smartlist of
`transport` line `char *`s, do you agree? And then as the bridgeauth we
reject the entire descriptor during parsing if a single `transport` line
contains an internal address?
Yes, I think that's our standard design for lists of strings.
> (If this takes me a while, perhaps it might make sense to split out the
bridge-side change from the bridgeauth-side change and merge them
independently?)
Splitting changes is usually helpful. Particularly when they need to be
merged to separate repositories.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31011#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs