[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8
#28081: rust protover discards all votes if one is not UTF-8
-------------------------------------------------+-------------------------
Reporter: cyberpunks | Owner: (none)
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.1-alpha
Severity: Normal | Resolution:
Keywords: rust, protover, | Actual Points:
035-deferred-20190115, 041-proposed, 033 |
-unreached-backport |
Parent ID: | Points:
Reviewer: ahf | Sponsor:
-------------------------------------------------+-------------------------
Comment (by cypherpunks):
Replying to [comment:15 ahf]:
> Is skipping "bad" entries in the Smartlist, silently, really a good
option here?
It's definitely a much better option than the current behavior of silently
discarding all entries, isn't it?
This was just supposed to be a simple bugfix, without going into the weeds
of more extensive improvements and refactoring this area of the code.
(Adding logging really requires refactoring.)
If you prefer to do them all at once instead, added logging and other
improvements here:
https://gitgud.io/onionk/tor/compare/master...rust-protover-unicode3
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28081#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs