[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32389 [Applications/Tor Browser]: Sandbox Graphite using RLBox for Linux

#32389: Sandbox Graphite using RLBox for Linux
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-security, GeorgKoppen202003,     |  Actual Points:
  TorBrowserTeam202003R                          |
Parent ID:  #32379                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-security, GeorgKoppen202002, TorBrowserTeam202003 => tbb-
     security, GeorgKoppen202003, TorBrowserTeam202003R
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 boklm]:
 > Replying to [comment:6 gk]:
 > > `bug_32389_v8` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32389_v8&id=6402b4ce975647e263611c49183456930dae461b)
 has the patch for review which is enabling RLBox for Graphite on Linux
 x86_64.
 > >
 > > As we talked on IRC I've included all the patches I backported in
 #32380 into a separate directory, `rlbox-patches`, in the `firefox`
 project. The commit message explains a bit why.
 >
 > I think the patches should be generated with `git format-patch -N`.
 >
 > Currently all patches contain `[PATCH n/m]` in the subject, where `m` is
 the total number of patches. This means that adding new patches (like in
 #33410) will require changing all patches to update `m`. I think using the
 `-N` option would avoid that.

 Well, I don't think that we need to update patches often, so I don't think
 that's a big issue. But I don't care strongly here, so I just did as you
 suggested: `bug_33410_v5` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_33410_v5&id=6c8d666b6de4f4ecd531a77d89806f459231e2df)
 has the updated patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32389#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs