[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32121 [Core Tor/Tor]: Refactor some common configs and functions out of the git scripts.
#32121: Refactor some common configs and functions out of the git scripts.
-------------------------------------------------+-------------------------
Reporter: teor | Owner: nickm
Type: enhancement | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: git-scripts, 044-should, | Actual Points: .5
043-backport |
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* keywords: git-scripts, 044-should => git-scripts, 044-should,
043-backport
* status: needs_review => merge_ready
* milestone: Tor: 0.4.4.x-final => Tor: 0.4.3.x-final
Comment:
Sooo I have found a typo I believe and instead of going back into another
round of reviews, I just fixed it. The suffix had an extra `r` with I
believe would be a typo? The `-s` results in:
{{{
_035
_r035
_041
_r041
_042
_r042
_043
_r043
_master
}}}
Here is the small fix:
{{{
- suffix="_r${brname_nodots#release-}"
+ suffix="_${brname_nodots#release-}"
}}}
I've merged this upstream and the fix is an extra commit
(a63b4148229ae8ce) so if by any chance it was on purpose, we can revert.
It doesn't affect any of us until we update the merging scripts so at
least there is an individual "revert path" we can do and work on any
fixes.
Moving this to 043 for backport consideration as per teor's request. I
will let you decide to which version you want it teor for backport.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32121#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs