[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33361 [Core Tor/Tor]: relay: Warn about the lack of ContactInfo and the consequence
#33361: relay: Warn about the lack of ContactInfo and the consequence
-------------------------------------------------+-------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 035-backport, 041-backport, | Actual Points:
042-backport, 043-backport, network-health |
Parent ID: | Points: 0.1
Reviewer: gk | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => merge_ready
Comment:
The fixup commits look good to me
(`6a4912fab5c80cf2e64b0a7909497ae8c2da1952` on `ticket33361_043_01` and
`e7829ce2a4ac1c1cd0728c1a6b6bdf89ea545375` on `ticket33361_035_01`). Not
sure what the process in the network-team is to get those branches merged,
like does the one merging patches require a squashed branch before? Or do
they do the squashing while merging? Either way, this looks ready from my
PoV. I am happy to look over a squashed and rebased branch against
`master` again to make sure no issues crept in while squashing, if that's
part of the procedure. :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33361#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs