[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible
#31634: Check .may_include order and tor subsystem init order are compatible
--------------------------------------+------------------------------------
Reporter: teor | Owner: nickm
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: diagnostics, practracker | Actual Points: 0.5
Parent ID: | Points: 2
Reviewer: teor | Sponsor:
--------------------------------------+------------------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
Sorry it's taken me a while to review this, I've been busy with some
urgent things the past few weeks.
The code looks good, I added comments about a few typos and tweaks.
There are a few conflicts between this PR and master.
I think I ran `tor --dbg-dump-subsystem-list` and `practracker/includes.py
--check-subsystem-order` the way you expect, and got the expected results.
But I'm not sure.
Can we add the relevant commands to `make check`?
Then I can run it locally, and in CI, and confirm we got the expected
results.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31634#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs