[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32994 [Core Tor/Tor]: Get all flag defaults from port_cfg_new()

#32994: Get all flag defaults from port_cfg_new()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, technical-debt, tor-   |  Actual Points:  0.2
  client, easy, intro, outreachy-ipv6            |
Parent ID:                                       |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  technical-debt, tor-client, easy, intro, outreachy-ipv6 =>
     extra-review, technical-debt, tor-client, easy, intro, outreachy-ipv6
 * status:  needs_review => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.4.4.x-final
 * reviewer:   => teor
 * actualpoints:   => 0.2


Comment:

 Thanks for this PR, it looks really good!

 It's normal for reviewers to request changes.

 I listed the changes I'd like to see in my review on the pull request:
 https://github.com/torproject/tor/pull/1795#pullrequestreview-374129928

 I'm also marking this ticket for extra review, to make sure I didn't miss
 anything. Someone else will have a look at it after I'm done reviewing it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32994#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs