[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32994 [Core Tor/Tor]: Get all flag defaults from port_cfg_new()

#32994: Get all flag defaults from port_cfg_new()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, technical-debt, tor-   |  Actual Points:  0.3
  client, easy, intro, outreachy-ipv6            |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by MrSquanchee):

 > teor : if you like my changes than we are almost done.

 That's a very clever hack something most of us new programmers are unable
 to.

 Added a changes file and added the irritating space before the label on
 line 6509 config.c

 Let me know if I did the changes file correctly ticket#32994.

 I think it's ready for a final review :)

 I just want to get over my first PR.

 @https://github.com/torproject/tor/pull/1795

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32994#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs