[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33600 [Core Tor/sbws]: max_pending_results is not used in main_loop anymore
#33600: max_pending_results is not used in main_loop anymore
-------------------------------+-----------------------------
Reporter: gk | Owner: gk
Type: defect | Status: merge_ready
Priority: Low | Milestone:
Component: Core Tor/sbws | Version:
Severity: Minor | Resolution:
Keywords: GeorgKoppen202003 | Actual Points:
Parent ID: | Points:
Reviewer: juga | Sponsor:
-------------------------------+-----------------------------
Comment (by gk):
Replying to [comment:2 juga]:
> lgtm. I'd just change the docstring comment about `max_pending_results`,
but we can merge as it is.
I had been thinking about that. But my reasoning for leaving it as-is was
that it is implicit available due to `pool` which is
`Pool(max_pending_results)`. Thus, I thought it makes sense to leave the
explicit reference to `max_pending_results` in the docstring to explain
what is going on. But I am fine either way.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33600#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs