Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33556: Add TBB project for android-components
--------------------------------------+------------------------------
 Reporter:  sisbell                   |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile, Android       |  Actual Points:
Parent ID:  #33184                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by sisbell):

 * cc: eighthave (removed)
 * status:  new => needs_review


Comment:

 Made the following changes

 Remove projects that we don't need from .buildconfig.yml

 Push Related

  * concept-push


  * feature-accounts-push


  * feature-push


  * lib-push-amazon


  * lib-push-firebase



 Accounts

  * feature-accounts


  * service-firefox-accounts



 Synch

  * feature-syncedtabs


  * browser-storage-sync


  * service-sync-logins



 Glean/Telemetry

  * service-glean


  * support-sync-telemetry



 Rust

  * support-rustlog


  * support-rusthttp



 Crash Reporting

  * lib-crash - (feature-push and service-firefox-accounts both depend on
 this, since they are removed we can remove this project)



 Miscs

  * service-experiments


  * support-migration (may need this)


  * support-test-appservices (removing all appservices components)


  * all sample projects



 Add mavenLocal() in build configs to reference local repo

 Use legacy setup for plugins so that they can find plugin artifact in
 local maven repo

 Since we are removing glean/telemetry support

  * Remove glean plugin references from gradle build files


  * Remove glean GekoAdapter.kt from builds.



 Add @aar to dependency references. The build is not finding these library
 artifacts locally without specifying type It looks for them as a jar)

 Remove use of git plugin. This is used to embed the hash in the meta-data,
 which we don't want to do

 TODOs:

  1. leftover change to rustlog version in path to remove


  1. The local maven repo section in the command line doesn't work
 correctly anymore. I had to copy artifacts to the standard .m2 repo. This
 needs investigation


  1. [wiki:PluginManagement Plugin Management section I added in
 settings.gradle doesn't do anything. This requires patching as a legacy
 plugin. Needs investigation.]


  1. The gradle-depenency file is outdated. It may not need everything in
 with the latest removal of projects from the .buildconfig.yml file. I'll
 need to regenerate it.


  1. We have variants for production, beta and nightly builds. These should
 be configurable based on the rbm build (currently fenix only supports
 using beta and nightly build, so only uses the respective variants  of
 android-components, meaning it doesn't use android-components production
 artifacts)Le



 Latest commit is here

 !https://github.com/sisbell/tor-browser-build/commits/bug-33556b

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33556#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs