[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19251 [Applications/Tor Browser]: TorBrowser might want to have an error page specific to when .onion links fail

#19251: TorBrowser might want to have an error page specific to when .onion links
fail
--------------------------------------------+------------------------------
 Reporter:  cypherpunks                     |          Owner:  brade
     Type:  enhancement                     |         Status:  needs_review
 Priority:  Low                             |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ux-team, TorBrowserTeam202003R  |  Actual Points:  6.7
Parent ID:  #30025                          |         Points:  6
 Reviewer:  acat,pospeselr                  |        Sponsor:
                                            |  Sponsor27-must
--------------------------------------------+------------------------------

Comment (by pospeselr):

 Ok, a few nits but overall looks good to me:

 - the svgs aren't as small/optimized as they could be, I've attached
 replacements:
  - browser.svg -> https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/19251/browser.svg
  - network.svg -> https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/19251/network.svg
  - onionsite.svg -> https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/19251/onionsite.svg
 - JavaScript has a Map type now ( https://developer.mozilla.org/en-
 US/docs/Web/JavaScript/Reference/Global_Objects/Map ), and I think (?)
 it's best practice to use them rather than the old Object with named
 fields pattern (for instance, in diagramInfoMap in _insertDiagram()). I
 know acat gave similar feedback on one of my patches at some point but I
 don't quite remember the justification.
 - hexErrorFromName could be reduced by having the returns under each case,
 rather than assign && break but I don't feel particularly strongly about
 it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19251#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs