[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33643 [Core Tor/Tor]: Appveyor: OpenSSL version mismatch in unit tests, 2020 edition
#33643: Appveyor: OpenSSL version mismatch in unit tests, 2020 edition
-------------------------------------------------+-------------------------
Reporter: teor | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-ci-fail, appveyor, windows, | Actual Points:
035-backport, 041-backport, 042-backport, |
043-backport, consider-backport-after-ci- |
passes |
Parent ID: | Points: 0.5
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Description changed by teor:
Old description:
> It's happened again:
> {{{
> OpenSSL library version 1.1.1d did not begin with header version 1.1.1e.
> }}}
> https://ci.appveyor.com/project/torproject/tor/builds/31549942/job/v0i9svtg78gqln1v#L6380
>
> Just like #32449, #28574, #28399 and #25942.
>
> We think our tests are fragile, because they are not copying the
> necessary libraries into `${env:build}/src/test` from `C:/mingw32/lib`:
> {{{
> ssl
> crypto
> lzma
> event
> zstd
> }}}
> at https://github.com/ahf/tor/blob/master/.appveyor.yml#L98-L99
>
> These libraries might have different dll prefixes or suffixes, for
> example, OpenSSL is:
> {{{
> /mingw32/bin/libcrypto-1_1.dll
> /mingw32/bin/libssl-1_1.dll
> }}}
> https://packages.msys2.org/package/mingw-w64-i686-openssl
>
> We might also want to copy these libraries into the same directory as the
> tor executable, before we run the tests that launch tor.
New description:
It's happened again:
{{{
OpenSSL library version 1.1.1d did not begin with header version 1.1.1e.
}}}
https://ci.appveyor.com/project/torproject/tor/builds/31549942/job/v0i9svtg78gqln1v#L6380
Just like #32449, #28574, #28399 and #25942.
We think our tests are fragile, because they are not copying the necessary
libraries into `${env:build}/src/test` from `C:/mingw32/lib`:
{{{
ssl
crypto
lzma
event
zstd
}}}
We already copy zlib and ssp at
https://github.com/ahf/tor/blob/master/.appveyor.yml#L98-L99 .
These libraries might have different dll prefixes or suffixes, for
example, OpenSSL is:
{{{
/mingw32/bin/libcrypto-1_1.dll
/mingw32/bin/libssl-1_1.dll
}}}
https://packages.msys2.org/package/mingw-w64-i686-openssl
We might also want to copy these libraries into the same directory as the
tor executable `${env:build}/src/app`, before we run the tests that launch
tor.
--
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33643#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs