[tor-bugs] #33665 [Circumvention/Snowflake]: Add command-line options for unsafe logging

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33665: Add command-line options for unsafe logging
-----------------------------------------+----------------------
     Reporter:  dcf                      |      Owner:  arlolra
         Type:  enhancement              |     Status:  assigned
     Priority:  Medium                   |  Milestone:
    Component:  Circumvention/Snowflake  |    Version:
     Severity:  Normal                   |   Keywords:
Actual Points:                           |  Parent ID:
       Points:                           |   Reviewer:
      Sponsor:                           |
-----------------------------------------+----------------------
 Moved from comment:4:ticket:33157

 >>> Something like that patch was useful when working on #19026 so would
 you consider merging,
 https://github.com/keroserene/snowflake/commit/dbd733e4b1430c046ec11e8052efdbac6010e58a
 >>>
 >> It's okay with me but I would call the option --unsafe-logging instead
 of --unsafeLogging to match the style of the other options.
 >>
 > In `broker/broker.go`, yes, dashes are used (ex. `disable-tls`, `acme-
 email`, etc), however, in `client/snowflake.go` we have camel casing (ex.
 `logToStateDir`, `keepLocalAddresses`, etc)
 >
 > We should probably consolidate this now.  I imagine your preference is
 for the former?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33665>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs