[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19251 [Applications/Tor Browser]: TorBrowser might want to have an error page specific to when .onion links fail

#19251: TorBrowser might want to have an error page specific to when .onion links
fail
--------------------------------------------+------------------------------
 Reporter:  cypherpunks                     |          Owner:  brade
     Type:  enhancement                     |         Status:  needs_review
 Priority:  Low                             |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ux-team, TorBrowserTeam202003R  |  Actual Points:  6.7
Parent ID:  #30025                          |         Points:  6
 Reviewer:  acat,pospeselr                  |        Sponsor:
                                            |  Sponsor27-must
--------------------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:45 pospeselr]:
 > I would say make diagramInfoMap a member variable of
 OnionServicesAboutNetError to avoid rebuilding it each time _insertDiagram
 is called. Apart from that, looks good to me.

 Thanks. Here is a revised tor-browser patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug30237-04&id=6cac185d0c10e4f26ca7eaf000c31fae36d13bfc

 The Torbutton patch is unchanged:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19251-03&id=7ce7e376fc8f3e51cf5de04f1a254c9190e3364b

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19251#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs