[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31967 [Circumvention/BridgeDB]: BridgeDB Server uses insecure pseudorandom generator for selecting cached captcha

#31967: BridgeDB Server uses insecure pseudorandom generator for selecting cached
captcha
------------------------------------+-----------------------------------
 Reporter:  willbarr                |          Owner:  (none)
     Type:  defect                  |         Status:  needs_revision
 Priority:  Medium                  |      Milestone:
Component:  Circumvention/BridgeDB  |        Version:  sbws: unspecified
 Severity:  Normal                  |     Resolution:
 Keywords:                          |  Actual Points:
Parent ID:                          |         Points:
 Reviewer:                          |        Sponsor:
------------------------------------+-----------------------------------
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 The patch removes the line that initialises `imagePath`. That's not
 supposed to happen, right? Also, there's a tab at the beginning of the
 newly added line, followed by spaces, which breaks indentation. Can you
 please fix these two issues?

 The patch subject should probably not be "Fixed broken patch" because it's
 not fixing a broken patch. Rather, it's changing the RNG :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31967#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs