Re: [tor-bugs] #32994 [Core Tor/Tor]: Get all flag defaults from port_cfg_new()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32994: Get all flag defaults from port_cfg_new()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, technical-debt, tor-   |  Actual Points:  0.3
  client, easy, intro, outreachy-ipv6            |
Parent ID:                                       |         Points:  1
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 This looks good.

 A nice follow up patch to this would be to change some of the integer
 values that we use with only zero and ones to be C99 `bool`'s instead of
 integers :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32994#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs