[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33676 [Core Tor/Chutney]: Stop waiting a set time for microdescriptors
#33676: Stop waiting a set time for microdescriptors
-------------------------------------------+-------------------------------
Reporter: teor | Owner: anuradha1904
Type: enhancement | Status: assigned
Priority: Medium | Milestone:
Component: Core Tor/Chutney | Version:
Severity: Normal | Resolution:
Keywords: ipv6, prop311, outreachy-ipv6 | Actual Points:
Parent ID: #33428 | Points: 0.5
Reviewer: teor | Sponsor: Sponsor55-can
-------------------------------------------+-------------------------------
Description changed by teor:
Old description:
> When we make chutney check for microdescriptors, we can stop waiting a
> set time for microdescriptors to download.
>
> Please read these instructions carefully. Don't leave out any steps!
>
> First, set MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO to
> 0:
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L926
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L952
>
> Then check that `make test-network-all` still passes on:
> * Tor master, and
> * Tor maint-0.3.5
>
> You can build a different tor branch using the following commands:
> {{{
> git checkout <branch>
> make
> }}}
>
> Check the new code on your own machine, and then submit a pull request to
> run Chutney's CI.
>
> If all those tests pass, you can remove all the code that uses
> MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO:
> * remove NODE_WAIT_FOR_UNCHECKED_DIR_INFO
> * replace NODE_WAIT_FOR_UNCHECKED_DIR_INFO with 0 in
> getUncheckedDirInfoWaitTime()
> * remove getMinStartTime()
> * remove all the constants getMinStartTime() uses
> * remove all calls to getMinStartTime()
> * remove all the variables, code, and comments that depend on
> getMinStartTime()
> *
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2224
> *
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2273
>
> Then add a commit to your pull request with these changes, and check that
> they pass CI.
New description:
Your code in #33675 needs to pass your local "make test-network-all", on
master and maint-0.3.5, before you start this ticket.
When we make chutney check for microdescriptors, we can stop waiting a set
time for microdescriptors to download.
Please read these instructions carefully. Don't leave out any steps!
First, set MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO to
0:
https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L926
https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L952
Then check that `make test-network-all` still passes on:
* Tor master, and
* Tor maint-0.3.5
You can build a different tor branch using the following commands:
{{{
git checkout <branch>
make
}}}
Check the new code on your own machine, and then submit a pull request to
run Chutney's CI.
If all those tests pass, you can remove all the code that uses
MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO:
* remove NODE_WAIT_FOR_UNCHECKED_DIR_INFO
* replace NODE_WAIT_FOR_UNCHECKED_DIR_INFO with 0 in
getUncheckedDirInfoWaitTime()
* remove getMinStartTime()
* remove all the constants getMinStartTime() uses
* remove all calls to getMinStartTime()
* remove all the variables, code, and comments that depend on
getMinStartTime()
*
https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2224
*
https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2273
Then add a commit to your pull request with these changes, and check that
they pass CI.
You can ignore macOS hangs ("red ! symbol") on Travis CI. It is a bit
unstable right now.
--
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33676#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs