[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6
#33679: Make sure every address function that takes for_listening supports IPv6
-------------------------------------------+-------------------------------
Reporter: teor | Owner: MrSquanchee
Type: task | Status: needs_review
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: prop312, ipv6, outreachy-ipv6 | Actual Points:
Parent ID: #33049 | Points: 0.5
Reviewer: | Sponsor:
| Sponsor55-must
-------------------------------------------+-------------------------------
Comment (by teor):
"n" stands for network-order, and "h" stands for host order. tor_addr_t is
always in host order. So we don't need these extra functions. When we are
refactoring, or adding features, we don't add extra functions. Unless we
are going to actually use them.
I put some more comments on the pull request.
Thanks for trying to make these functions simpler. But they also need to
be correct, and readable. Sometimes a function is more readable, if it is
written using multiple lines.
Let's just focus on changing and testing tor_addr_is_valid() for now. I
think the other functions are fine.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33679#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs