[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31699 [Core Tor/Tor]: Remove unused configure.ac checks
#31699: Remove unused configure.ac checks
--------------------------+----------------------------------
Reporter: nickm | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: unspecified
Component: Core Tor/Tor | Version: Tor: unspecified
Severity: Normal | Resolution:
Keywords: easy | Actual Points:
Parent ID: #31698 | Points:
Reviewer: | Sponsor:
--------------------------+----------------------------------
Comment (by bduszel):
I think I was able to clear some of the entries mentioned by nickm.
There are separate commits for each entry to make it easier to pick/drop
changes if needed and also to make the review process easier. I removed
checks for:
- getpass,
- syslimits,
- htonll,
- EVP_sha3_256,
- malloc,
- libcap.
Script output after the changes:
{{{
AC_APPLE_UNIVERSAL_BUILD
HAVE_EVENT2_BUFFEREVENT_SSL_H
HAVE_EVENT2_DNS_H
HAVE_EVENT2_EVENT_H
HAVE_STRUCT_TCP_INFO_TCPI_SND_MSS
HAVE_STRUCT_TCP_INFO_TCPI_UNACKED
HAVE_U_CHAR
PACKAGE_URL
SIZEOF_SHA_CTX
SRCDIR
USE_ANDROID
_LARGE_FILES
_MINIX
_POSIX_1_SOURCE
_POSIX_SOURCE
_REENTRANT
}}}
For now I'm too afraid to remove `EVENT2`, `TCP_INFO` and `U_CHAR`. I need
to read about autoconf more to do this. Maybe I will look for some help on
`#tor-dev` and clear the rest.
If someone could take a look at changes made so far that would be great.
MR: https://github.com/torproject/tor/pull/1835
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31699#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs