[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33762 [Core Tor/Tor]: OnionService v3 running as onionbalance backend fails to reload failing with get_subcredential_for_handling_intro2_cell: Non-fatal assertion !(!service->ob_subcreds) failed.
#33762: OnionService v3 running as onionbalance backend fails to reload failing
with get_subcredential_for_handling_intro2_cell: Non-fatal assertion
!(!service->ob_subcreds) failed.
----------------------------------+----------------------------------------
Reporter: s7r | Owner: (none)
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor | Version: Tor: 0.4.4.0-alpha-dev
Severity: Normal | Resolution:
Keywords: tor-hs, onionbalance | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet, s7r | Sponsor:
----------------------------------+----------------------------------------
Comment (by s7r):
fix works. if the code also looks good to @dgoulet this can be merged -
it's very important, otherwise log rotate systems that send SIGHUPs will
make backend instances totally unavailable until they build their next
descriptors. very bad.
P.S.: is it a problem that it displays '''info''' prefixed log messages
for the functions listed in the bottom of the ticket description?
Shouldn't (at least) `ob_option_parse(): OnionBalance:
MasterOnionAddress...` be '''notice''' level? This is a very important
step for the operator to confirm that a particular backend instance has
been able to register to its management server instance, and by
'''notice''' is Tor's default log level.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33762#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs