[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6
#33679: Make sure every address function that takes for_listening supports IPv6
-------------------------------------------------+-------------------------
Reporter: teor | Owner:
| MrSquanchee
Type: task | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: extra-review, prop312, ipv6, | Actual Points: 0.3
outreachy-ipv6, network-team-roadmap-2020Q1 |
Parent ID: #33049 | Points: 0.5
Reviewer: | Sponsor:
| Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by teor):
* keywords: prop312, ipv6, outreachy-ipv6, network-team-roadmap-2020Q1 =>
extra-review, prop312, ipv6, outreachy-ipv6, network-team-roadmap-
2020Q1
* reviewer: teor =>
* actualpoints: => 0.3
Comment:
Now that we have unit tests, it is easier to simplify the function a bit
more:
https://github.com/torproject/tor/pull/1848
I think the check for the 0.0.0.0 IPv4 address was redundant.
I added this commit, what do you think?
https://github.com/torproject/tor/pull/1848/commits/ba68603d648d28d22e89acf1be8ea3c590836daf
Now that the pull request is finished, someone else will review it, then
it will be merged. That should take about a week or so.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33679#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs