[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser
#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-------------------------------------+------------------------
Reporter: cohosh | Owner: (none)
Type: task | Status: new
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor:
-------------------------------------+------------------------
Comment (by dcf):
Is it necessary to patch the source? Or could we just remove the
dependencies from projects/pion-webrtc/config and delete the projects? It
seems to me that the quic parts of pion-webrtc are not built by default;
all the involved files have a `+build quic`
[https://golang.org/pkg/go/build/#hdr-Build_Constraints build constraint].
In the [https://github.com/pion/webrtc/blob/v2.2.0/.travis.yml#L53
upstream CI] they have to specifically pass `-tags quic` to `go build`.
On the other hand, if in #28325 the Tor Browser team starts using go.mod
files directly for dependency tracking (as we are kind of currently doing
with the gomodtorbm script), then it makes sense to patch the source and
get a new go.mod, as you've done.
What tor-browser-build projects does it allow to be removed? My reckoning
from a quick grep is pion-quic, quic-go, genny, ginkgo, gomega, gomock,
qtls.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33761#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs