[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3035 [Tor Client]: fix a few clang-static analyzer complaints in 0.2.2

#3035: fix a few clang-static analyzer complaints in 0.2.2
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 re  4a02eb37c97e: I'm pretty sure we don't change the changelogs for
 releases that have already happened.

 re the change to connection_or.c : If you're removing the out += len, you
 should also change the following *out++ = 0; to just be *out = 0; , IMO

 Otherwise looks fine.   Resolving those, squashing, and merging.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3035#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs