[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3135 [Tor Client]: Tor segfaults on saveconf if it can't read its torrc file (was: Saveconf request can terminate tor)
#3135: Tor segfaults on saveconf if it can't read its torrc file
------------------------+---------------------------------------------------
Reporter: atagar | Owner:
Type: defect | Status: new
Priority: major | Milestone: Tor: 0.2.1.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Changes (by arma):
* component: Tor Relay => Tor Client
* version: Tor: 0.2.3.1-alpha =>
* milestone: Tor: 0.2.3.x-final => Tor: 0.2.1.x-final
Comment:
Here's the code:
{{{
case FN_FILE:
old_val = read_file_to_str(fname, 0, NULL);
if (strcmpstart(old_val, GENERATED_FILE_PREFIX)) {
rename_old = 1;
}
}}}
We're not checking if read_file_to_str fails. This bug is also in
maint-0.2.1.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3135#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs