Re: [tor-bugs] #2355 [Tor Client]: Change UseBridges to prevent any access attempts of public tor network

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#2355: Change UseBridges to prevent any access attempts of public tor network
-----------------------------------+----------------------------------------
    Reporter:  anonym              |        Type:  defect    
      Status:  needs_review        |    Priority:  major     
   Milestone:  Tor: 0.2.2.x-final  |   Component:  Tor Client
     Version:                      |    Keywords:            
      Parent:                      |      Points:            
Actualpoints:                      |  
-----------------------------------+----------------------------------------

Comment(by nickm):

 Replying to [comment:32 arma]:
 > Replying to [comment:31 nickm]:
 > > I did a backport and light tidy in branch "bug2355" in my public repo.
 anonym should have a look to make sure it's sane.
 >
 > Looks fine overall.
 >
 > Major points:
 >
 > - 6c528a1b7415e should not be in there. A different version of it is
 already in maint-0.2.2.
 >
 > - f602eab961b2 seems to have snuck in too. I don't yet believe that it
 does anything good.

 I'd like to hear anonym's take on these.

 > Minor points:
 >
 > - In the or.h patch, it says
 > {{{
 > 1 means strictly yes, 0 means stricly no,
 > }}}
 > I think that should be "1" and "0" rather than bare values. Also,
 stricly -> strictly.
 >
 > - UseBriges -> UseBridges
 >
 > - The changes entry should say that the default changed too.

 Will fix.

 > - For our new CONFIG_TYPE_PORT we say strcasecmp when checking if
 "auto", but here we say strcmp?

 Hm.  I think both should be strcmp.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2355#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs