[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4592 [Tor Relay]: tor_tls_server_info_callback(): SSL3_ST_SW_SRVR_HELLO_B missed.

#4592: tor_tls_server_info_callback(): SSL3_ST_SW_SRVR_HELLO_B missed.
--------------------------+-------------------------------------------------
    Reporter:  troll_un   |       Owner:                    
        Type:  defect     |      Status:  needs_review      
    Priority:  normal     |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Relay  |     Version:  Tor: 0.2.2.34     
  Resolution:             |    Keywords:                    
      Parent:  #4668      |      Points:                    
Actualpoints:             |  
--------------------------+-------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Replying to [comment:9 nickm]:
 > Sounds like we should apply one of these.  Looking at the openssl code,
 my only worry here is that we might double-count handshakes, by triggering
 both for the SW_SRVR_HELLO_A and SW_SRVR_HELLO_B step of the same
 handshake.  Is that a possibility do you think?

 Ah, the "if (ret <= 0) goto end;" is the crucial bit.  We shouldn't get an
 info_cb until one of the SW_SRVR_HELLO_* actually has a successful
 ssl3_send_server_hello, which will cause it to transition out.  So asn's
 second patch above ought to be safe.  Turning it into a branch as
 "bug4592".

 My inner coward says to merge this into 0.2.3.x, though it would apply to
 0.2.2.x too.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4592#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs