[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8860 [Flashproxy]: Registration over App Engine
#8860: Registration over App Engine
------------------------+---------------------------------------------------
Reporter: dcf | Owner: dcf
Type: project | Status: needs_review
Priority: major | Milestone:
Component: Flashproxy | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by arlolra):
Replying to [comment:7 asn]:
> Oh there is codez here. Nice!
Thanks for the comments.
>
> Some comments on the code:
> - You can just connect to 'https://www.google.com' instead of
'https://www.google.com/ip' and
`urlparse.urljoin("https://www.google.com/reg/";, reg)`.
Are you sure? How else would I specify the request path?
>
> - Exception handling in `get_external_ip()` is kind of crude. Also, its
callers are not prepared for it returning None.
I updated my branch here:
https://github.com/arlolra/flashproxy/compare/master...appspot
to return an empty string, instead of `None`.
>
> - Can we use flashproxy's normal `parse_addr_spec()`?
Not sure what you mean. Most of `flashproxy-reg-appspot` is a copy of what
was in `flashproxy-reg-url`.
>
> BTW, while this script will work great for now, an adversary might be
able to block it by detecting the SSL handshake of urllib2, in the same
way as they currently do for Tor. Maybe the next step is to build a
Firefox addon that does the registration through https://google.com?
Interesting idea.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8860#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs