Re: [tor-bugs] #8879 [Tor]: pidgin fails to do socks5 handshake with username/password auth

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#8879: pidgin fails to do socks5 handshake with username/password auth
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 Here's the code in pidgin's libpurple:
 {{{
         if ((connect_data->read_buffer[0] != 0x01) ||
 (connect_data->read_buffe
 r[1] != 0x00)) {
                 purple_proxy_connect_data_disconnect(connect_data,
                                 _("Received invalid data on connection
 with server"));
                 return;
         }
 }}}

 And sure enough, if I change Tor's response like this:
 {{{
 @@ -1750,7 +1755,7 @@ parse_socks(const char *data, size_t datalen,
 socks_reque
          return 0;
        }
        req->replylen = 2; /* 2 bytes of response */
 -      req->reply[0] = 5;
 +      req->reply[0] = 1; /* WRONG! should be 5. but appeases pidgin. */
        req->reply[1] = 0; /* authentication successful */
        log_debug(LD_APP,
                 "socks5: Accepted username/password without checking.");
 }}}
 then pidgin's handshake with Tor works.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8879#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs