[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8639 [Tor]: Controller: Stream event source field is "<unknown address type>:1" for DNS requests from the controller
#8639: Controller: Stream event source field is "<unknown address type>:1" for DNS
requests from the controller
---------------------------------+------------------------------------------
Reporter: Desoxy | Owner: andrea
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version: Tor: 0.2.4.11-alpha
Keywords: tor-spec tor-client | Parent:
Points: | Actualpoints:
---------------------------------+------------------------------------------
Comment(by andrea):
Replying to [comment:15 nickm]:
> Oh hang on; I'd worry that stuff will crash if there are connections
with address == NULL flying around the code. Look for ->address in
connection.c for example, and consider all the places we use it without
checking for whether it's NULL.
>
> What if we took the first version of your patch, and added the control.c
changes from the second version, but checked for
!strcmp(..,"(Tor_internal)") instead of NULL?
Ouch, the string form is that widely used? Okay, that would work; how
would you feel about an empty string instead for the sake of memory
savings?
Ick, it can't be just a string constant because if it isn't NULL something
will surely try to free it. Allocating a string per connection just to
flag "this is from an AF_UNIX control connection" seems really gross. :(
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8639#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs