[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7944 [Flashproxy]: Standalone flash proxy

#7944: Standalone flash proxy
-------------------------+--------------------------------------------------
 Reporter:  akrey        |          Owner:  dcf           
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Flashproxy   |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by dcf):

  * status:  needs_review => needs_revision


Comment:

 I rebased and squashed your latest `node.js` branch and pushed it to
 https://gitweb.torproject.org/user/dcf/flashproxy.git/shortlog/refs/heads/node.js
 (note it's under the /user/dcf directory this time).

 Please don't merge from master in feature branches like this one, if you
 can avoid it. I would much rather have you rebase onto master, in the same
 branch or in a new branch. You should rebase to get rid of commits that do
 something and then later commits that revert them. In these branches, I'm
 not interested in history, I want something clean that I can apply to
 master. See comment:5:ticket:7751 for a example of asn making such a
 rebased "take2" branch.

 Don't make changes like these that only change whitespace:
 https://github.com/arlolra/flashproxy/compare/node.js#L0L424
 https://github.com/arlolra/flashproxy/compare/node.js#L0R445
 https://github.com/arlolra/flashproxy/compare/node.js#L0L676
 If you notice changes like that in the diff, you need to rebase and get
 rid of them.

 I don't understand this commit:
 https://github.com/arlolra/flashproxy/commit/dbb8dec3c952983ef903fa3fd4e0c6859855bae6
 What is going on there? If it's necessary, you need to find another way to
 do it. Having `this` depend on who calls `make_websocket` is too magical.

 Is it still the case that `have_websocket_binary_frames` should return
 false for node.js?

 Could you add a document under `doc` that explains how to check out and
 run the standalone proxy? Then we can ask for testers.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7944#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs