[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11417 [Tor Weather]: add vagrant file for weather

#11417: add vagrant file for weather
-----------------------------+-----------------------------
     Reporter:  feverDream   |      Owner:  baumanno
         Type:  task         |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Weather  |    Version:
   Resolution:               |   Keywords:  weather-rewrite
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------

Comment (by karsten):

 Oh, nice!  Here's some feedback:

  - Do you know `git commit --squash` and `git commit --fixup`?  You could
 have made a single commit for each change and used `git commit --squash
 533b7688cbc004cde27c3263ff19cd997f251bfa` to imply that these commits
 shall be squashed before merging to another branch.  Not important, but
 can be useful at times.

  - Feel free to delete obsolete parts from `Vagrant.md`, rather than doing
 things like the "Stop here" trick.  Commented-out instructions are bit-
 rotting even faster than everything else.

  - Is there a way to avoid touching `weather/config/config.py`?  That is,
 can we have a `/home/weather/opt/current/` in the VM?  And can we leave
 `base_url` unchanged and still reach the web app under `weather.dev` or
 even `192.168.33.10`?

  - What is `weather/initial_data.json` for?  Can it be autogenerated by
 Django in the bootstrap process?

  - Same questions for `weather/settings.py` and `weather/weather.wsgi` as
 for `weather/config/config.py`: if we can, we should try not to touch
 these, or we'll make it more difficult to deploy weather to the production
 machine later.

  - You added a comment to GitHub: "I just realized I could have used
 PROJECT_PATH probably... we had to drop it due to the relative path,
 Django choked on the "../" Let's re-visit this later on down the line!"
 Can you elaborate?  And if using `PROJECT_PATH` makes things easier, can
 you add another comment on top using `git commit --squash`?

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11417#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs