[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9701 [Firefox Patch Issues]: Prevent TorBrowser from creating clipboardcache turds
#9701: Prevent TorBrowser from creating clipboardcache turds
-------------------------------------+-------------------------------------
Reporter: cypherpunks | Owner: mikeperry
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Firefox Patch | Version:
Issues | Keywords: tbb-disk-leak,
Resolution: | interview, GeorgKoppen201405,
Actual Points: | MikePerry201405R
Points: | Parent ID:
-------------------------------------+-------------------------------------
Comment (by gk):
Replying to [comment:10 mcs]:
> I think your proposed fix is OK. It might be better to add a preference
or a compile-time method to disable the WriteCache() code (Mozilla would
be more like to accept a patch that uses such an approach). For example,
the kLargeDatasetSize value could be retrieved from a preference and a
zero value could mean "never write to disk."
That would be one approach. But I'd be in favor of another one: binding it
to the state of the Private Browser Mode: if we are in PBM we don't write
to disk otherwise we do as I think the current behavior is just a
violation of the Private Browsing Mode paradigm (at least as we would like
to have it).
I tested the patch on all platforms and it is working fine.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9701#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs