[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15654 [Onionoo]: proper closing of BufferedWriter in LockFile.java

#15654: proper closing of BufferedWriter in LockFile.java
-----------------------------+-----------------
     Reporter:  firebrand    |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  trivial      |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------
Changes (by karsten):

 * cc: iwakeh (added)


Comment:

 The nested `try` blocks are not exactly pretty.  I wonder, should we
 switch to [http://docs.oracle.com/javase/7/docs/technotes/guides/language
 /try-with-resources.html try-with-resources]?  There are probably quite a
 few similar places in the codebase that we should fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15654#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs