Re: [tor-bugs] #13877 [Tor Browser]: Find a better solution for the configure hang than backing out the fix for bug 762358

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13877: Find a better solution for the configure hang than backing out the fix for
bug 762358
-----------------------------+----------------------------------
     Reporter:  gk           |      Owner:  gk
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  tbb-gitian, ff38-esr
Actual Points:               |  Parent ID:  #15772
       Points:               |
-----------------------------+----------------------------------

Comment (by gk):

 This turns out to be a libfaketime bug. I contacted the maintainer trying
 to upstream a patch for it. Quorting from that email:
 {{{
 The problem seems to be that strtok_r() is modifying the evnironment
 variable directly. Quoting from the getenv(3) man page:

 "As typically implemented, getenv() returns a pointer to a string within
 the environment list. The caller must take care not to modify this
 string, since that would change the environment of the process."

 The result is that FAKETIME_SKIP_CMDS, having been, say,
 "python2.7,make,rsync" is only "python2.7" after the first run.
 }}}
 We should `strdup()` the string and work on the result instead. This fixes
 our problem.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13877#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs