Re: [tor-bugs] #16030 [Tor]: Visual Studio 2013 Test Problems

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#16030: Visual Studio 2013 Test Problems
-------------------------------+------------------------------------
     Reporter:  NewEraCracker  |      Owner:
         Type:  defect         |     Status:  new
     Priority:  normal         |  Milestone:
    Component:  Tor            |    Version:  Tor: 0.2.6.7
   Resolution:                 |   Keywords:  tor-relay, msvc, lorax
Actual Points:                 |  Parent ID:  #13081
       Points:                 |
-------------------------------+------------------------------------

Comment (by NewEraCracker):

 Doing this change makes all channel related tests pass:
 {{{
 --- a/src/test/test_channel.c
 +++ b/src/test/test_channel.c
 @@ -420,6 +420,7 @@

    chan->close = chan_test_close;
    chan->get_overhead_estimate = chan_test_get_overhead_estimate;
 +  chan->get_remote_descr = chan_test_get_remote_descr;
    chan->num_bytes_queued = chan_test_num_bytes_queued;
    chan->num_cells_writeable = chan_test_num_cells_writeable;
    chan->write_cell = chan_test_write_cell;
 @@ -615,7 +616,6 @@
    /* Test channel_dump_statistics */
    ch->describe_transport = chan_test_describe_transport;
    ch->dumpstats = chan_test_dumpstats;
 -  ch->get_remote_descr = chan_test_get_remote_descr;
    ch->is_canonical = chan_test_is_canonical;
    old_count = test_dumpstats_calls;
    channel_dump_statistics(ch, LOG_DEBUG);
 }}}

 As now all fake channels will have a valid pointer to get_remote_descr.
 Yet I am not sure if this is the correct fix.

 Getting a stack trace in Visual Studio is a pain. But I'll see if there is
 anything I can do.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16030#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs