Re: [tor-bugs] #12498 [Tor]: Implement ed25519 identity keys (prop 220)

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#12498: Implement ed25519 identity keys (prop 220)
-------------------------+-------------------------------------------------
     Reporter:  asn      |      Owner:  nickm
         Type:  task     |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7
   Resolution:           |   Keywords:  026-triaged-1, 027-triaged-1-in,
Actual Points:           |  SponsorU
       Points:  large    |  Parent ID:  #15054
-------------------------+-------------------------------------------------

Comment (by nickm):

 Replying to [comment:24 dgoulet]:

 > * 660fff9e5b6cde9c43c87335c1e2661455b90317
 >  - I don't see any manual page entry for these option. On purpose maybe?
 > {{{
 > +  V(SigningKeyLifetime,              INTERVAL, "30 days"),
 > +  V(TestingLinkKeyLifetime,          INTERVAL, "2 days"),
 > +  V(TestingAuthKeyLifetime,          INTERVAL, "2 days"),
 > +  V(TestingLinkKeySlop,              INTERVAL, "3 hours"),
 > +  V(TestingAuthKeySlop,              INTERVAL, "3 hours"),
 > +  V(TestingSigningKeySlop,           INTERVAL, "1 day"),
 > }}}

 Whoops; should be fixed in 96ada96

 >  - config.c: Typo in REJECT message, missing "Testing":

 3163a7b312451896bd3c3d401dd0df8f8ff2d854 should fix.

 >
 > * 9641ea395b93ba444e9ab508ff4697ac34d0fed3
 > * 66772a26d8d4c662b41b7522075771c8697006b9
 >  - router.c: My guess here is that is a forgotten artefact? :)
 > {{{
 >  assert_identity_keys_ok(void)
 >  {
 > +  if (1)
 > +    return;
 > }}}
 >
 >  lgtm
 >
 > * ba911b29410c6b8f874beedaec072a10e2038da9
 >
 >  trivial fix. lgtm
 >
 > * 09fa94086aa1793a0f24fc81f4c9b49f66ba6c9f
 >
 >  lgtm
 >
 >
 > Final note, I reviewed the code correctness and what I could find in the
 proposals but keep in mind I'm not in a position to fully review the
 design nor comment on it. This is really a tor subsystem I am quite
 unfamiliar with :S.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12498#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs