[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18905 [Applications/Tor Browser]: Remove unused menu items from Tor Browser help menu
#18905: Remove unused menu items from Tor Browser help menu
--------------------------------------------+------------------------------
Reporter: arthuredelstein | Owner:
Type: defect | arthuredelstein
Priority: Medium | Status:
Component: Applications/Tor Browser | needs_revision
Severity: Normal | Milestone:
Keywords: ff45-esr, TorBrowserTeam201605 | Version:
Parent ID: | Resolution:
Reviewer: | Actual Points:
| Points:
| Sponsor:
--------------------------------------------+------------------------------
Comment (by arthuredelstein):
Replying to [comment:9 gk]:
> Alas, this breaks the whole menu as there is code that wants to
disable/enable the web forgery item. Removing the element results in
> {{{
> TypeError: document.getElementById(...) is null
> }}}
> in `browser-safebrowsing.hs` line 17. I guess just collapsing the item
would be enough?
Phooey. Thanks for noticing that error.
I tried using `style='display:none'` and "hidden='true'" but both fail to
make the menu item disappear in OS X. An approach that seems to work for
me is to remove the menuitems as before, but then introduce two dummy
`box` elements with the same id. So the code in `browser-safebrowsing.hs`
gets something to chew on.
https://github.com/arthuredelstein/torbutton/commit/a4d4a940b778e8151e649b02041a8f396d9175d0
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18905#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs