[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
---------------------------------------------+-----------------------------
 Reporter:  mcs                              |          Owner:  tbb-team
     Type:  defect                           |         Status:
 Priority:  Medium                           |  needs_review
Component:  Applications/Tor Browser         |      Milestone:
 Severity:  Normal                           |        Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  |     Resolution:
Parent ID:                                   |  Actual Points:
 Reviewer:                                   |         Points:
                                             |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by mcs):

 Replying to [comment:4 gk]:
 > Looks good to me. One nit: could you wrap that long line in
 `torbutton_update_sync_ui()`? It would make it a bit easier to read in my
 terminal.

 Maybe also add a try/catch in that function or check that the
 getElementById() succeeds. That way a failure there due to future Firefox
 changes won't break other Torbutton features such as the circuit display.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18743#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs