[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter
#18761: Make logging of rendezvous to private address quieter
-------------------------------------------------+-------------------------
Reporter: teor | Owner: nickm
Type: defect | Status:
Priority: Medium | merge_ready
Component: Core Tor/Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: must-fix-before-028-rc, tor-hs, | Version: Tor:
TorCoreTeam201605, TorCoreTeam- | 0.2.8.2-alpha
postponed-201604, review-group-1 | Resolution:
Parent ID: | Actual Points: very
Reviewer: asn | small
| Points: small
| Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_review => merge_ready
Comment:
LGTM.
Might be worth pointing out that this patch will also suppress the
following log message:
{{{
node = node_get_by_nickname(rp_nickname, 0);
if (!node) {
if (err_msg_out) {
tor_asprintf(&err_msg,
"Couldn't find router %s named in INTRODUCE2 cell",
escaped_safe_str_client(rp_nickname));
}
goto err;
}
}}}
Are we OK with hiding this from HS operators? I guess yes because it's not
like they can do anything about it (and it's probably caused by consensus
desynchronization between client and service).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18761#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs