[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19043 [Core Tor/Tor]: Implementation of Proposal 224 Section 3.1

#19043: Implementation of Proposal 224 Section 3.1
-------------------------------------+------------------------------------
 Reporter:  alec.heif                |          Owner:
     Type:  enhancement              |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-hs, prop224, 6.s194  |  Actual Points:
Parent ID:  #17241                   |         Points:
 Reviewer:  asn, dgoulet             |        Sponsor:  SponsorR-must
-------------------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hello Alec,

 thanks for all the code. Looks like a great start, and I think it will be
 very
 useful in the future!

 Now for some logistics: are you planning to work more on this? If yes,
 when
 should we expect updates here? These days we are actively working on
 implementing prop224, and the `ESTABLISH_INTRO` cell is one of our next
 steps, so
 I'd like to see if your schedule is compatible with our plans.

 As a first step, I took a look at your code and did a bit of review. You
 can
 find my comments and changes in my branch `prop224-alec` at:
     https://gitweb.torproject.org/user/asn/tor.git/log/?h=prop224-alec

 Note that there have been some recent prop224 torspec changes (like the
 keylen
 size) that impact the `ESTABLISH_INTRO` cell slightly.

 Here are some future steps on this area:

 - Address the XXXs I added to the code.

 - Write unit tests.

 - Move prop224 functions like `rend_mid_establish_intro_p224()` to their
 own file.
   Maybe call new file `hs_intro_point.c` or something. Also maybe rename
 that function to
   `rend_mid_handle_establish_intro_prop224()`?

 - Write function-level documentation.

 - Run `make check-spaces` and fix the various whitespace/style issues.

 Let me know if you plan to work on these, and if you have an ETA on
 delivery,
 so that we can count you in our implementation roadmap :)

 Cheers!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19043#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs