[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19142 [Core Tor/Tor]: Remove the environ configure check
#19142: Remove the environ configure check
--------------------------+---------------------
Reporter: cypherpunks | Owner:
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version:
Severity: Trivial | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+---------------------
Comment (by cypherpunks):
It turns out the `environ` variable cannot be redeclared because of
`-Wredundant-decls`. Instead i looked into why it was added and if it can
be removed.
It was initially added in commit
[https://gitweb.torproject.org/tor.git/commit/?id=efb7b9dec135594718b765234bc1f745855f60d2
efb7b9dec135594718b765234bc1f745855f60d2] because (according to the
comment) FreeBSD needed it. The
[https://www.freebsd.org/cgi/man.cgi?query=environ&apropos=0&sektion=0&manpath=FreeBSD+10.3-RELEASE&arch=default&format=html
man page] (all the way back to FreeBSD 1.0) tells us otherwise. If someone
could give the reasoning why FreeBSD requires declaring `environ` that
would be helpful because i don't have a FreeBSD machine and cannot test it
myself.
In commit
[https://gitweb.torproject.org/tor.git/commit/?id=bc66878bdea0250991fc99b2d023146f67a6f4bb
bc66878bdea0250991fc99b2d023146f67a6f4bb] the environ configure check was
added because it gave redundant declaration warnings on Linux. These were
the exact same warnings i got when testing redeclaring `environ`
unconditionally.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19142#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs