[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18914 [Applications/Tor Browser]: Consider removing <isindex>
#18914: Consider removing <isindex>
---------------------------------------------+-----------------------------
Reporter: mcs | Owner: tbb-team
Type: defect | Status:
Priority: Medium | needs_review
Component: Applications/Tor Browser | Milestone:
Severity: Normal | Version:
Keywords: ff45-esr, TorBrowserTeam201605R | Resolution:
Parent ID: | Actual Points:
Reviewer: | Points:
| Sponsor:
---------------------------------------------+-----------------------------
Comment (by arthuredelstein):
Replying to [comment:5 mcs]:
> Replying to [comment:3 arthuredelstein]:
> > Here's a patch that uses an English-only label on `<isindex/>` tags.
The localized tag is removed. This provides an easy fix while we wait for
Mozilla to remove the <isindex> support altogether.
> >
> > https://github.com/arthuredelstein/tor-browser/commit/18914+1
> > Hash 018cc9788c202df10a9f6aceaac12af12bd672b6
>
> This is a good solution.
> Is it safe to use u"..." string literals for all compilers?
> Mozilla code usually uses NS_LITERAL_STRING.
> Otherwise, the changes look good.
Good point. Here's a revised version using NS_LITERAL_STRING.
https://github.com/arthuredelstein/tor-browser/commit/18914+2
Hash 3c2c77205ee2bf92abd975fbed310cfcd57e74dc
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18914#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs